Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#7238: Fix docstring inheritance for cached_property and use it #7239

Merged
merged 2 commits into from
May 8, 2024
Merged

FIX-#7238: Fix docstring inheritance for cached_property and use it #7239

merged 2 commits into from
May 8, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 7, 2024 •
edited
Loading

What do these changes do?

Blocked on #7241

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Use cached_property #7238
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev force-pushed the issue7238 branch 2 times, most recently from 8bec7f2 to bb43cd5 Compare May 8, 2024 11:38
@anmyachev
FIX-modin-project#7238: Fix docstring inheritance for 'cached_propert…
5dfb3de 
…y' and use it

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev changed the title REFACTOR-#7238: Use cached_property FIX-#7238: Fix docstring inheritance for cached_property and use it May 8, 2024
@anmyachev
use '__set_name__' when needed
2b95b2a 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review May 8, 2024 12:55
@anmyachev anmyachev merged commit 06699a8 into modin-project:main May 8, 2024
38 checks passed
@anmyachev anmyachev deleted the issue7238 branch May 8, 2024 14:23
@korbit-ai korbit-ai bot mentioned this pull request Aug 13, 2024
Closed
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
@korbit-ai korbit-ai bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use cached_property
2 participants
@anmyachev @YarShev