Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#7224: Importing modin.pandas.api.extensions overwrites re-export of pandas.api submodules #7225

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

noloerino
Copy link
Collaborator

What do these changes do?

This PR re-exports the submodules of pandas.api from within modin/pandas/api/__init__.py to ensure they are not overwritten when a user tries to import modin.pandas.api.extensions.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Importing modin.pandas.api.extensions overwrites re-export of pandas.api submodules #7224
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev
Copy link
Collaborator

YarShev commented Apr 30, 2024

@noloerino, could you sign your commit off?

@noloerino
Copy link
Collaborator Author

@YarShev is it not already signed? I see the "Verified" badge next to it on GitHub, and I can see my GPG signature in git log --show-signature.

@YarShev
Copy link
Collaborator

YarShev commented Apr 30, 2024

There is no your email address. Can I use Jonathan Shi jhshi@ponder.io to sign your commit when merging?

…tes re-export of pandas.api submodules

Signed-off-by: Jonathan Shi <jhshi07@gmail.com>
@noloerino
Copy link
Collaborator Author

Sorry about that, I added -s this time (I forgot the signed-off-by message is different from GPG signing).

For future reference, since Ponder got acquired by Snowflake a few months ago, our @ponder.io emails no longer work, so I'll be signing commits with my personal email (jhshi07@gmail.com) on this GitHub account for continuity. My @snowflake.com email is tied to a different GitHub account (@sfc-gh-joshi), so I don't think I should be using that email to sign unless I make a PR with that account.

@YarShev YarShev merged commit db1bddc into modin-project:main Apr 30, 2024
36 checks passed
@noloerino noloerino deleted the pd-api-overwrite branch April 30, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Importing modin.pandas.api.extensions overwrites re-export of pandas.api submodules
2 participants