Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-#7217: Update docs as to when Modin operators work best #7218

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Apr 25, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Update docs as to when Modin operators work best #7217
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

…best

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@dchigarev
Copy link
Collaborator

dchigarev commented Apr 25, 2024

Suggestion for groupby section:

This operator performs best when the cardinality of 'by' columns is low (small number of output groups). At the Map stage, the operator computes the aggregation for each row partition individually, meaning, that the Reduce stage takes a dataframe with the following number of rows: num_groups * n_row_parts. If the number of groups is too high, there's a risk of getting a dataframe with even bigger than the initial shape at the Reduce stage.

Example:

initial_nrows = 1_000
num_groups = 800
num_row_parts = 16

Reduce stage input shape: num_groups * num_row_parts = 800 * 16 = 12_800 rows (12 times bigger than the initial shape,
                                                                               even full-column implementation would have done better)

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@anmyachev anmyachev merged commit 74cf1cf into modin-project:main Apr 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs as to when Modin operators work best
3 participants