Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#7178: Add type hints for DataFrame #7179

Merged
merged 1 commit into from
Apr 15, 2024
Merged

FEAT-#7178: Add type hints for DataFrame #7179

merged 1 commit into from
Apr 15, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Apr 13, 2024 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add type hints for DataFrame #7178
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FEAT-modin-project#7178: Add type hints for DataFrame
145be2a 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 13, 2024
View reviewed changes
modin/pandas/dataframe.py
@@ -2591,7 +2632,7 @@
)
object.__setattr__(self, key, value)

def __setitem__(self, key, value):
def __setitem__(self, key, value) -> None:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
modin/pandas/dataframe.py
Comment on lines +2939 to +2941
def _create_or_update_from_compiler(
self, new_query_compiler, inplace=False
) -> Union[DataFrame, None]:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
modin/pandas/dataframe.py
@@ -3108,7 +3153,7 @@
"""
return Series(query_compiler=query_compiler)

def _set_axis_name(self, name, axis=0, inplace=False):
def _set_axis_name(self, name, axis=0, inplace=False) -> Union[DataFrame, None]:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
@anmyachev anmyachev marked this pull request as ready for review April 13, 2024 17:01
@YarShev YarShev merged commit c7ef02a into modin-project:master Apr 15, 2024
38 checks passed
@anmyachev anmyachev deleted the issue7178 branch April 15, 2024 12:17
@korbit-ai korbit-ai bot mentioned this pull request Aug 13, 2024
Closed
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
@korbit-ai korbit-ai bot mentioned this pull request Aug 15, 2024
Open
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type hints for DataFrame
2 participants
@anmyachev @YarShev