Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#7165: Add codecov token to fix CI on master #7175

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Fix upload coverage #7165
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@YarShev
Copy link
Collaborator

YarShev commented Apr 11, 2024

@sfc-gh-mvashishtha, is this PR ready for review? Also, we should probably replace "main" to "master" in the PR title as we haven't changed master branch to main yet.

@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title TEST-#7165: Add codecov token to fix CI on main TEST-#7165: Add codecov token to fix CI on master Apr 11, 2024
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review April 11, 2024 21:03
@sfc-gh-mvashishtha
Copy link
Contributor Author

@YarShev ready for review

Also, we should probably replace "main" to "master" in the PR title as we haven't changed master branch to main yet.

Done.

@YarShev YarShev merged commit 2b046e4 into modin-project:master Apr 11, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix upload coverage
2 participants