Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#7105: Deprecate 'cfg.RangePartitioningGroupby' #7161

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Apr 9, 2024

What do these changes do?

Deprecate cfg.RangePartitioningGroupby in favor of cfg.RangePartitioning

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Recommend using cfg.RangePartitioning instead of cfg.RangePartitioningGroupby in docs #7105
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@@ -775,16 +791,24 @@ def _sibling(cls) -> type[EnvWithSibilings]:
)


class RangePartitioning(EnvironmentVariable, type=bool):
def use_range_partitioning_groupby() -> bool:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the technique of making RangePartitioning and RangePartitioningGroupby siblings (as we did it before with ExperimentalGroupbyImpl) won't work here, since we don't want for them to actually share the same value (if they would be siblings, RangePartitioningGroupby.put(True) would enable other range-part implementations, not only groupby) that's why introducing this hacky helper function for now

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev marked this pull request as ready for review April 10, 2024 19:35
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmyachev
Copy link
Collaborator

@dchigarev should we merge the PR before the next release or after?

@dchigarev
Copy link
Collaborator Author

I think we should merge it before release cc @YarShev ?

@YarShev YarShev merged commit fe57e19 into modin-project:master Apr 11, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend using cfg.RangePartitioning instead of cfg.RangePartitioningGroupby in docs
3 participants