Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#7106: Rename from/to_ray_dataset to from/to_ray #7107

Merged
merged 2 commits into from
Mar 19, 2024
Merged

REFACTOR-#7106: Rename from/to_ray_dataset to from/to_ray #7107

merged 2 commits into from
Mar 19, 2024

Conversation

Retribution98
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Rename from/to_ray_dataset to from/to_ray. #7106
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@Retribution98
REFACTOR-modin-project#7106: Rename from/to_ray_dataset to from/to_ray
b71b45a 
Signed-off-by: Kirill Suvorov <kirill.suvorov@intel.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 19, 2024
View reviewed changes
modin/pandas/accessor.py
@@ -31,7 +31,7 @@
from modin import pandas as pd
from modin.error_message import ErrorMessage
from modin.logging import ClassLogger
from modin.pandas.io import to_dask, to_ray_dataset
from modin.pandas.io import to_dask, to_ray

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
modin.pandas.io
Loading
begins an import cycle.
YarShev
YarShev reviewed Mar 19, 2024
View reviewed changes
docs/ecosystem.rst Outdated Show resolved Hide resolved
@YarShev YarShev merged commit 7c835a2 into modin-project:master Mar 19, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename from/to_ray_dataset to from/to_ray.
2 participants
@Retribution98 @YarShev