TEST-#7076: Explicitly check for exceptions in test_map_metadata.py
#7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
YarShev
reviewed
Mar 13, 2024
| "Expected a 1D array, got an array with shape (3, 2)" | ||
| ) | ||
| elif idx == 2: | ||
| # Modin's exception message looks better, it's probably fine just leave it as is |
There was a problem hiding this comment.
Can you provide an example of the messages from Modin and pandas? Even if our message looks better, why should we not match pandas?
There was a problem hiding this comment.
I created new issues. Let’s decide it separately?
YarShev
reviewed
Mar 13, 2024
| raising_exceptions = None | ||
| if "float_nan_data" in request.node.callspec.id: | ||
| # Modin's exception message looks better, it's probably fine just leave it as is | ||
| raising_exceptions = False |
YarShev
reviewed
Mar 13, 2024
| @@ -1648,13 +1684,6 @@ def test___invert___bool(): | |||
| df_equals(modin_result, pandas_result) | |||
|
|
|||
|
|
|||
| def test___hash__(): | |||
There was a problem hiding this comment.
dataframes are no longer hashable.
>>> import pandas as pd
>>> hash(pd.DataFrame([1,2,3,4]))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: unhashable type: 'DataFrame'
YarShev
reviewed
Mar 13, 2024
…_metadata.py' Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
|
@YarShev ready for review |
YarShev
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -stest_map_metadata.py#7076docs/development/architecture.rstis up-to-date