FIX-#7051: Update exception message for astype function
#7052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
Mar 11, 2024
| @@ -900,10 +900,18 @@ def execute_callable(fn, inplace=False, md_kwargs={}, pd_kwargs={}): | |||
| ), "Got Modin Exception type {}, but pandas Exception type {} was expected".format( | |||
| type(md_e), type(pd_e) | |||
| ) | |||
| if raising_exceptions: | |||
| if raising_exceptions and isinstance(raising_exceptions, (list, tuple)): | |||
There was a problem hiding this comment.
This code branch is temporary and will be removed in #6954.
There was a problem hiding this comment.
How will this complicate further development until #6954 is merged?
There was a problem hiding this comment.
In general, it shouldn’t complicate things in any way, since this parameter is still optional.
anmyachev
commented
Mar 11, 2024
| assert not isinstance( | ||
| md_e, tuple(raising_exceptions) | ||
| ), f"not acceptable exception type: {md_e}" | ||
| elif raising_exceptions and type(raising_exceptions) is type: |
There was a problem hiding this comment.
type(raising_exceptions) is type: - сhecking to ensure that it is not the class that is being passed, but its instance
There was a problem hiding this comment.
I don't quite get this. Could you provide an example of passing such an instance?
There was a problem hiding this comment.
>>> type(TypeError) is type
True
>>> type(TypeError("something")) is type
False
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
|
@YarShev please take a look I still decided to divide it into parts to simplify the review. |
YarShev
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Part of #6954
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sastypefunction in the case of duplicated values #7051docs/development/architecture.rstis up-to-date