Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6968: Align API with pandas #6969

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Feb 26, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add skipna parameter to some groupby and resample methods #6968
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
environment-dev.yml Outdated Show resolved Hide resolved
@dchigarev dchigarev marked this pull request as ready for review February 26, 2024 15:25
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
modin/pandas/groupby.py Outdated Show resolved Hide resolved
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@YarShev YarShev merged commit a1d5dd4 into modin-project:master Feb 26, 2024
36 checks passed
anmyachev pushed a commit that referenced this pull request Jun 10, 2024
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skipna parameter to some groupby and resample methods
5 participants