Resolve #108 - training data transformations should not be reused #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r on_transformed strategies
Codecov Report
@@ Coverage Diff @@
## dev #113 +/- ##
==========================================
+ Coverage 96.68% 96.80% +0.12%
==========================================
Files 31 31
Lines 1779 1786 +7
==========================================
+ Hits 1720 1729 +9
+ Misses 59 57 -2
Continue to review full report at Codecov.
|
|
@BoyanH Any update on merging the PR? |
|
@nawabhussain Sorry, it was on me. I got even more behind my work during the holidays, so I haven't got time to do it. I am getting started with it now. |
|
Merged the PR, thanks! Pushing a new release (0.4.1) to PyPI soon. |
|
Thank you for your work @BoyanH @cosmic-cortex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
Transformed training data was originally stored as an optimization to not re-transform data between queries. Such an approach is faulty for all learnable transformatons, as these are changed after model retraining. The transformed training data is hence no longer stored.