chore(ios): Update SSZipArchive to 2.5.5 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@plrthink Hello. Could you take a look this PR? |
|
OK, would release this right now. |
|
@plrthink |
|
Damn, it looks like we need to revert it( |
|
@balmasich @vomchik Yes, I just found out that. Although it's a breaking change, I think we have to since it's needed for submitting to the app store. |
|
According to forks' feedback on this change, I just realized we should not update the deployment target internally, this makes many apps, that can't update the deployment target, unable to adapt the updates anymore. Instead, we should let the developers do this themself. So I just the v6.1.2, which reverted this PR. And if you're going to submit it to the app store, please follow the guide on the readme. |
|
@plrthink thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this issue