Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress is not updated #184

Closed
pvroosendaal opened this issue Dec 31, 2019 · 6 comments
Closed

Progress is not updated #184

pvroosendaal opened this issue Dec 31, 2019 · 6 comments
Assignees

Comments

@pvroosendaal
Copy link

pvroosendaal commented Dec 31, 2019

Hi,

Wonderful utility, working great! However, when I'm zipping a folder with images and video's, the progress is not updated in the subscribe event.
I'm getting progress 0 at start and 1 when it's completed, but nothing in between.

Can you help out?

I'm on version 5.0.0, testing on iPhone X with iOS 13.3

@plrthink
Copy link
Collaborator

plrthink commented Jan 7, 2020

could you show the snippet you're using?

@pvroosendaal
Copy link
Author

I have a FileService class with the following function, where subscribe(callback) is the subscribe function from this lib.

subscribeToArchiving(callback: ({ progress: number, filePath: string })) {
    this.archiveProgressEvent = subscribe(callback)
}

And I'm calling that with the following snippet:

this.fileService.subscribeToArchiving(({ progress, filePath }) => {      
    console.log("subscribeToArchiving()", progress)
    this.setState({ archiveProgress: progress })
})

@plrthink
Copy link
Collaborator

Oh, sorry for the late response. Actually we haven't implemented the real progress event for archiving on iOS yet. It's just the faked version.

But it seems to be easy to accomplish. I would like to introduce this in the next release.

@pvroosendaal
Copy link
Author

Ok, thanks for the info. Hope to see this enhancement soon!

@plrthink
Copy link
Collaborator

Hi, I just published version 5.0.2-beta.1 which includes this feature. Can you try it out? Please note that currently, I cannot emit the file being zipped out, so the filePath passed to the callback would always the empty string.

plrthink added a commit that referenced this issue Mar 18, 2020
@plrthink
Copy link
Collaborator

closed via version 5.0.2

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants