Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap packet errors with cause information #39

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Mar 14, 2022

Follow up from #29 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #39 (ab4ab13) into v1.1.2 (9c6f602) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           v1.1.2      #39   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          19       19           
  Lines        2028     2028           
=======================================
  Hits         2005     2005           
  Misses         20       20           
  Partials        3        3           
Impacted Files Coverage Δ
server/internal/packets/packets.go 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mochi-co mochi-co added the enhancement New feature or request label Mar 15, 2022
@mochi-co
Copy link
Collaborator

You put me to shame ;-) I will have endeavour to provide better error handling in the future. This is great!

@mochi-co mochi-co merged commit 17253ad into mochi-mqtt:v1.1.2 Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants