Only transform file import path if not already transformed

[christian-bromann]

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• All new code requires tests to ensure against regressions.

Description of the Change

Passing in a file path, e.g. file:///foo/bar in Node causes problems as Mocha tries to resolve the path, e.g.:

path.resolve('file:///foo/bar.spec.js') // returns "/path/to/cwd/file:/foo/bar.spec.js"

Alternate Designs

n/a

Why should this be in core?

This seems to be a bug in core.

Benefits

It allows Mocha to use file urls. This is important for Windows where import('d:\foo\bar.spec.js') is not possible.

Possible Drawbacks

n/a

Applicable issues

n/a

[coveralls]

Coverage increased (+0.002%) to 94.329% when pulling 0d9992a on christian-bromann:cb-respect-file-urls into 023f548 on mochajs:master.

[erwinheitzman]

@christian-bromann let's get the linting fixed (spaces vs tabs issue?) and hopefully the team will look at this :)

[github-actions]

This PR hasn't had any recent activity, and I'm labeling it stale. Remove the label or comment or this PR will be closed in 14 days. Thanks for contributing to Mocha!

[github-actions]

This PR hasn't had any recent activity, and I'm labeling it stale. Remove the label or comment or this PR will be closed in 14 days. Thanks for contributing to Mocha!

[christian-bromann]

Closing as it seems the project is not interested in the change.

[JoshuaKGoldberg]

👋 coming back to this @christian-bromann, are you still interested in working on this PR? As of #5027 there are maintainers who can review it now. No worries if you no longer have time - but if you do that'd be great!

Note that I don't see any linked issues. The contributing guidelines right now ask for that so that folks can discuss the change first. We'll continue to require that after #5038. Was there any impetus for this PR besides what's in the description and linked webdriverio issues?

[christian-bromann]

Hey @JoshuaKGoldberg 👋 thanks so much for reaching out. Unfortunately I am not exactly sure what the underlying issue was. I think I struggled with path issues in Windows when porting the WebdriverIO code base to ESM. I am not sure how I worked around it but there isn't any issue anymore, for me at least.

Thanks for picking up the maintenance on this 🙏