Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add "options.require" to Mocha constructor for root hooks on parallel runs. #4630

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Apr 24, 2021

Description of the Change

#closes #4575

The root hooks aren't executed when Mocha is run programmatically and in parallel.
In parallel mode it's necessary to pass the path of the rootHooks plugin to the mocha instance as this information is not available via IPC to the worker processes.

We add options.require to the API docs for the Mocha constructor. No code change is required.

@juergba juergba self-assigned this Apr 24, 2021
@juergba juergba added area: documentation anything involving docs or mochajs.org area: parallel mode Regarding parallel mode labels Apr 24, 2021
@juergba juergba requested a review from a team April 24, 2021 08:43
@juergba juergba merged commit d35eb9d into master Apr 30, 2021
@juergba juergba added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Apr 30, 2021
@juergba juergba added this to the next milestone Apr 30, 2021
@juergba juergba deleted the juergba/parallel_rootHooks branch April 30, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org area: parallel mode Regarding parallel mode semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root hook plugins not running when run in parallel with API (works through CLI)
1 participant