Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for this.test.error() behavior in "after each" hooks #4519

Merged
merged 1 commit into from
Nov 24, 2020
Merged

add test for this.test.error() behavior in "after each" hooks #4519

merged 1 commit into from
Nov 24, 2020

Conversation

boneskull
Copy link
Contributor

  • cleanup test/integration/hook-err.spec.js
  • add default params for runMochaJSONAsync() helper
  • expand "to have passed/failed tests" assertions (for JSON reporter output) to allow matching against fullTitle prop
  • rename some fixtures to lowercase

prompted by #4515

@boneskull
add test for this.test.error() behavior in "after each" hooks
e7ce9a6 
- cleanup `test/integration/hook-err.spec.js`
- add default params for `runMochaJSONAsync()` helper
- expand "to have passed/failed tests" assertions (for JSON reporter output) to allow matching against `fullTitle` prop
- rename some fixtures to lowercase
@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Nov 23, 2020
@boneskull boneskull self-assigned this Nov 23, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.143% when pulling e7ce9a6 on boneskull/after-each-this-test-error-test into 78a41d1 on master.

@boneskull boneskull merged commit bc8ce05 into master Nov 24, 2020
@boneskull boneskull deleted the boneskull/after-each-this-test-error-test branch November 24, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@boneskull boneskull

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boneskull @coveralls