This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
5.4.0 CDN version cannot be used #608
Comments
|
Which CDN url are you using?
Op di 20 nov. 2018 om 08:59 schreef Feng Hao <notifications@github.com>:
… ReferenceError: require is not defined
The reason for the error is this code:
require("react-is")
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#608>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhOXuJjpD0FAIwW6rvS67tRad9LNSks5uw7Z7gaJpZM4YqkMx>
.
|
https://unpkg.com/mobx-react@5.3.6/index.min.js can be used, but 5.4.0 does not work |
|
@flyinghail seems to be a rollup issue, 5.4.1 should fix it, could you confirm? |
|
@mweststrate there is a new error |
|
Ah that is an actual error! Could you open a separate issue on that,
isolated with the component that throws it? It means that a ForwardRef is
not built up the way mobx-react expects it
Op di 20 nov. 2018 om 09:34 schreef Feng Hao <notifications@github.com>:
… @mweststrate <https://github.com/mweststrate> there is a new error
···
Error: render property of ForwardRef was not a function
···
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#608 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhKTy3s5CdFJY29wcO7WRi1_OmyD7ks5uw76OgaJpZM4YqkMx>
.
|
|
@marksilvis I see the code. |
noscripter
added a commit
to noscripter/mobx-react
that referenced
this issue
Nov 30, 2018
* fix: jest test jsdom SecurityError ref: jsdom/jsdom#2304 * Add link to mobx-react-lite (mobxjs#603) * Create a failing test for React.forwardRef * Refs are now properly forwarded * observer + forwardRef is now reactive * Minor tweak, updated changelog * Fixed weird minification issue * Published version 5.4.0 * Fixed rollup issue, fixes mobxjs#608 * Published version 5.4.1 * Fixed issue with ForwardRef being bundled as undefined * Published version 5.4.2 * Cleaner implementation of forwardRef * Added open question
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The reason for the error is this code:
The text was updated successfully, but these errors were encountered: