-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android changes #23
base: master
Are you sure you want to change the base?
Android changes #23
Conversation
Thanks for the modification. Would it be better to change the static import directly as |
Your pull request has a build error, which is caused by invalid maven pom.xml configuration: https://travis-ci.org/mob41/broadlink-java-api/builds/570753996 Removing the changes or fixing the invalid characters can help. Btw, what is the |
Is there any chance of getting this PR included? The ability to use the library with java 11 would be super nice. I added a PR onto the PR to fix the pom-file (https://github.com/psiniemi/broadlink-java-api/pulls) but no feedback so far. |
Unless author accepts your PR or makes changes to his code, I couldn’t merge two branches together cause it could break changes. |
Remove incorrect characters from pom file
Sorry, completely forgot about this and somehow missed the notifications until now. Will look into the comments this weekend. |
Hi, static imports are pretty much a question of taste. The only downside I see is that if there are a lot of them, it can make following the code quite confusing. I like to use them as it makes the code shorter and as long as the name of the function name says what it does, I find it easier to follow. But since it appears our tastes differ, I removed the static import. |
To run on older android devices, I needed to remove references to Byte.toUnsignedInt and newer javas also don't ship with javax.xml anymore, so I also removed javax.xml.bind.DatatypeConverter which was only used for bytes -> hex conversion and replaced with a HexUtil class that can do the conversion both ways.