Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored #12

Conversation

mnajdova
Copy link
Owner

@mnajdova mnajdova commented Nov 5, 2020

Addressing comment mui#23370 (review)

Copy link

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section would still require an overhaul since it contains outdated/misleading information from the classes API.

const componentName = path.basename(component.filename).replace(/\.js$/, '');
const cssFilename = `../data/css/${camelCaseToKebabCase(componentName)}-css.js`;
try {
const cssModule = require(cssFilename);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just read the json with fs-extra. require is slowly getting replace and with require we have to rely on webpack.

Copy link
Owner Author

@mnajdova mnajdova Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted the file to .json and used readFileSync. Should we merge this on the main branch? Edit: merged this one on the main branch, we can continue discussion there to be more visible.

@mnajdova
Copy link
Owner Author

mnajdova commented Nov 6, 2020

The section would still require an overhaul since it contains outdated/misleading information from the classes API.

These classes are still used in the theme overrides as keys, it is not misleading information. We just don't support the classes prop

@mnajdova mnajdova merged commit df0e3eb into feat/update-buildAPI-to-support-ComponentClassKey Nov 6, 2020
@eps1lon
Copy link

eps1lon commented Nov 6, 2020

These classes are still used in the theme overrides as keys, it is not misleading information. We just don't support the classes prop

How is it not misleading to mention the classes prop if it's not implemented?

@mnajdova
Copy link
Owner Author

mnajdova commented Nov 6, 2020

How is it not misleading to mention the classes prop if it's not implemented?

The classes keys are still used as keys in the styleOverrides inside the theme. Where am I mentioning the classes prop?

mnajdova pushed a commit that referenced this pull request Nov 10, 2020
Move picker sources into lab (#4)

Update README.md

[DatePicker] Refactor pickers tests to testing-library and mocha (#5)

[TimePicker] Migrate tests to testing library (#8)

[DateTimePicker] Migrate tests  (#9)

Fix all pickers linter errors (#10)

Fix all circular dependencies (#11)

* Fix all circular dependencies

* Enable mocha eslint rules for typescript tests

[test] The last step to a green CI (#15)

Migrate pickers docs (#12)

Downgrade to withStyles for pickers sources (#16)

Add public api exports for pickers components (#17)

Consolidate component namespace and theme augmentation  (#18)

Describe conformance for pickers sub-components (#19)

Autogenerate proptypes for typescript sources  (#20)

Proper build output (#21)

Clear migration artifacts  (#23)

Eslint rule for lower-case test name convention  (#24)

DateRangePicker  (#25)

yarn deduplicate

Remove GridListTile

[DateTimePicker] Fix migration unit tests

Fix types

Fix typescript types migration issues

Fix yarn lerna build (#33)

Fix karma tests

use window.Touch for CI karma tests

Remove more outdated diff noise (#34)

Replace not valid formats with valid ISO strings

Try to fix CI touch tests

Skip tests if Touch events are not supported

Fix merge conflicts

Actually type-check

Fix safari tests

Remove lowercase test name rule

The casing is up to the test author.
We're not the grammar police in tests.

Fix lint

Format

Remove overzealous eslint-disable*

Debug failing tests

Better debugging

Timezones are fun

was isoString th efix?

Let's find out what's failing and then skip it

Branch for safari

Skip DateRangePicker in browsers

review

Matt's review

Co-authored-by: Matt <github@nospam.33m.co>

format

docs:i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants