Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema.org dates to ISO-8601 #2339

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

perelo
Copy link
Contributor

@perelo perelo commented Dec 4, 2019

This is a bug fix.

Summary

It seems that schema.org's date data type should be ISO-8601. So I updated datePublished and dateModified format to date_to_xmlschema.

@@ -13,7 +13,7 @@ <h3 class="comment__author" itemprop="author" itemscope itemtype="https://schema
<p class="comment__date">
{% if include.date %}
{% if include.index %}<a href="#comment{{ include.index }}" itemprop="url">{% endif %}
<time datetime="{{ include.date | date_to_xmlschema }}" itemprop="datePublished">{{ include.date | date: "%B %d, %Y at %I:%M %p" }}</time>
<time datetime="{{ include.date | date_to_xmlschema }}" itemprop="datePublished">{{ include.date | date_to_xmlschema }}</time>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<time> is already using date_to_xmlschema for the datetime attribute. My understanding the time between <time></time> is the human readable format and not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right ! I reverted it.

@mmistakes mmistakes merged commit af528d4 into mmistakes:master Dec 19, 2019
kamil-adam pushed a commit to twocolumn/minimal-mistakes that referenced this pull request Apr 1, 2020
* Fix schema.org dates to ISO-8601

* Revert date_to_xmlschema in <time> tag
jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this pull request Jul 8, 2020
* Fix schema.org dates to ISO-8601

* Revert date_to_xmlschema in <time> tag
kamil-adam pushed a commit to twocolumn/minimal-mistakes that referenced this pull request Mar 15, 2021
* Fix schema.org dates to ISO-8601

* Revert date_to_xmlschema in <time> tag
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
* Fix schema.org dates to ISO-8601

* Revert date_to_xmlschema in <time> tag
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
* Fix schema.org dates to ISO-8601

* Revert date_to_xmlschema in <time> tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants