Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/thirdparty: standard library crypto/ed25519 #225

Merged
merged 4 commits into from
Apr 24, 2022

Conversation

mmcloughlin
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #225 (07b9714) into master (b758297) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   76.07%   76.08%   +0.01%     
==========================================
  Files          65       65              
  Lines       20552    20552              
==========================================
+ Hits        15634    15637       +3     
+ Misses       4839     4838       -1     
+ Partials       79       77       -2     
Flag Coverage Δ
integration 11.84% <ø> (ø)
unittests 73.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/thirdparty/config.go 83.33% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b758297...07b9714. Read the comment docs.

@mmcloughlin
Copy link
Owner Author

There seems to be an issue with GOROOT that should be easy to fix, but the bigger problem is just how long make.bash takes. Can we install Go from a release instead? Or use the go install golang.org/dl/go1.17.3@latest method? What about the -latest test mode in that case?

@mmcloughlin mmcloughlin force-pushed the tests-thirdparty-golang-go-ed25519 branch from 2b28d44 to 07b9714 Compare April 24, 2022 04:17
@mmcloughlin mmcloughlin marked this pull request as ready for review April 24, 2022 04:29
@mmcloughlin mmcloughlin merged commit f1f7d93 into master Apr 24, 2022
@mmcloughlin mmcloughlin deleted the tests-thirdparty-golang-go-ed25519 branch April 24, 2022 04:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants