Fix OpenBSD support #999
Merged
Fix OpenBSD support #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBSD does not have LC_NUMERIC locale support.
|
Please change this to draft, add all commits you need to fix the build, and then submit it for review (instead of numerous PRs). |
It's the last diff I have. I submitted multiple PRs as most projects want self contained separate diffs instead of one big diff. |
|
Yeah, well, "fix the OpenBSD" is self-contained IMO, and a PR can hold multiple commits. OK, thanks for the update! |
The commit message was poor, I admit that and I was going to update it to something better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD does not have LC_NUMERIC locale support.