Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash connecting a NULL producer #979

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

j-b-m
Copy link
Contributor

@j-b-m j-b-m commented Apr 12, 2024

Debugging a Kdenlive crash, I came upon an MLT file that consistently crashed melt.
The .mlt file was buggy, missing an XML playlist, still I think it's good if we can fix the crash in MLT.
My patch doesn't allow anymore to connect a null producer to the service. Let me know if you think there is a reason to allow that.

A sample of a crashing malformed .mlt file, the playlist1 defined at the end as a track producer is never defined :


<?xml version="1.0"?>
<mlt LC_NUMERIC="C" version="7.23.0">
  <producer id="producer0" in="0" out="14999">
    <property name="length">15000</property>
    <property name="eof">pause</property>
    <property name="resource">red</property>
    <property name="mlt_service">color</property>
  </producer>
  <playlist id="playlist0">
    <entry producer="producer0" in="0" out="14999"/>
  </playlist>
  <tractor id="tractor0" title="color:red" in="0" out="14999">
    <track producer="playlist0"/>
    <track producer="playlist1"/>
  </tractor>
</mlt>

@ddennedy ddennedy merged commit b2a82de into mltframework:master Apr 12, 2024
6 checks passed
@ddennedy ddennedy added this to the v7.24.0 milestone Apr 12, 2024
travier added a commit to flathub/org.kde.kdenlive that referenced this pull request Apr 19, 2024
travier added a commit to flathub/org.kde.kdenlive that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants