Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx install of yml file for audioseam filter #936

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

j-b-m
Copy link
Contributor

@j-b-m j-b-m commented Aug 1, 2023

The audioseam yml file currently doesn't install because the CMakeLists.txt is broken

@ddennedy ddennedy merged commit 8b6cc9b into mltframework:master Aug 1, 2023
6 checks passed
@ddennedy ddennedy added this to the v7.20.0 milestone Aug 1, 2023
@j-b-m
Copy link
Contributor Author

j-b-m commented Aug 3, 2023 via email

@ddennedy
Copy link
Member

ddennedy commented Aug 3, 2023

Those are target dependencies and make the files appear in IDEs such as Qt Creator. There is a separate install command where these are not included. I also checked last daily (macos) build log here in Actions, and see there is no longer lines showing these two files get installed. Fix it!!

@j-b-m
Copy link
Contributor Author

j-b-m commented Aug 3, 2023

Fixed, sorry for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants