GPS text: added grade, cadence, temperature + some small updates #934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a quick note about the re-formatting rules: in the long if..else if chains with multiple lines of code inside each if block it absolutely needs a newline somewhere between each if block otherwise the entire chain looks like a huge blob of text and finding something is harder than it needs to be (see the code below line 281 in the first diff below).
For short blocks it does look nice and cozy but those are readable no matter how you write them.