Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #931 Blank producer in playlist does not have audio normalization #932

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Fix #931 Blank producer in playlist does not have audio normalization #932

merged 3 commits into from
Aug 20, 2023

Conversation

bmatherly
Copy link
Member

  • Add new blank producer
  • Use the blank producer in the playlist so that blank frames have normalization filters attached.

One side effect of this is that a playlist must be initialized with a profile. Some of the normalization filters depend on it.

@bmatherly
Fix mltframework#931 Blank producer in playlist does not have audio n…
c835881 
…ormalization

* Add new blank producer
* Use the blank producer in the playlist so that blank frames have
  normalization filters attached.
ddennedy
ddennedy requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@ddennedy ddennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mlt_playlist_init() should be deprecated. Playlist::Playlist() depends on it, but it could call mlt_playlist_new(nullptr) as I am not sure we can remove that constructor.

src/framework/mlt_playlist.h Outdated Show resolved Hide resolved
src/modules/core/producer_blank.yml Outdated Show resolved Hide resolved
src/modules/core/producer_blank.c Outdated Show resolved Hide resolved
src/modules/core/producer_blank.c Outdated Show resolved Hide resolved
@bmatherly
Copy link
Member Author

I think mlt_playlist_init() should be deprecated. Playlist::Playlist() depends on it, but it could call mlt_playlist_new(nullptr) as I am not sure we can remove that constructor.

Done

@ddennedy ddennedy added this to the v7.20.0 milestone Aug 20, 2023
@ddennedy ddennedy merged commit 0eae1a0 into mltframework:master Aug 20, 2023
6 checks passed
@bmatherly bmatherly deleted the blank_producer branch November 6, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddennedy ddennedy ddennedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bmatherly @ddennedy