Fix full range override #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for: https://forum.shotcut.org/t/23-04-color-range-regression/38609 The "force_full_range" parameter was not being taken into account because it is only calculated when the producer is opened. Additionally, workaround an issue that full range conversion does does not work for 420P->420P.
bmatherly
commented
May 4, 2023
| @@ -1586,6 +1586,16 @@ static int convert_image_yuvp(producer_avformat self, | |||
| int dst_full_range) | |||
| { | |||
| int result = self->yuv_colorspace; | |||
|
|
|||
| // Workaround: swscale does not convert the range if the src & dst are both 420P | |||
There was a problem hiding this comment.
I think this was recently uncovered because the deinterlace filter is no longer requesting 422 if deinterlacing is not required. I was not able to find a way to get the swscale API to convert between full and mpeg ranges if both source and destination are 420P.
|
There were some things I did not like in this PR, but it very much inspired my commit 97dcafd that does not require a Shotcut change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for:
https://forum.shotcut.org/t/23-04-color-range-regression/38609
The "force_full_range" parameter was not being taken into account because it is only calculated when the producer is opened.
Additionally, workaround an issue that full range conversion does does not work for 420P->420P.