Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rl examples #225

Closed
wants to merge 10 commits into from
Closed

Conversation

Ali-Hossam
Copy link

This PR offers a refactored Reinforcement learning .cpp examples so that they work with the new mlpack API

Copy link

github-actions bot commented Apr 8, 2024

Binder 👈 Launch a binder notebook on branch Ali-Hossam/examples/refactor_rl_examples

@Ali-Hossam Ali-Hossam closed this Apr 11, 2024
@rcurtin
Copy link
Member

rcurtin commented Apr 11, 2024

Are these just the C++ fixes from #223? (If so we can just handle these changes there.)

@Ali-Hossam
Copy link
Author

Yes they are the same, i just noticed that i made two PRs instead of one. Should i close #223 and reopen this? @rcurtin

@rcurtin
Copy link
Member

rcurtin commented Apr 11, 2024

Nah, #223 is just fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants