df.corr should add additional argument to handle string data

[tunglinwood]

1. (Minor) add !pip install packages including statsmodels , folium, and most important mlpack to avoid errors if user try on Jupyter notebook online.
2. (Major)since pandas version 2.0.0 now you need to add numeric_only=True param to avoid the issue

[mlpack-bot]

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

• All code should follow the style guide
• Documentation added for any new functionality
• Tests added for any new functionality
• Tests that are added follow the testing guide
• Headers and license information added to the top of any new code files
• HISTORY.md updated if the changes are big or user-facing
• All CI checks should be passing

Thank you again for your contributions! 👍

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[github-actions]

👈 Launch a binder notebook on branch tunglinwood/examples/patch-1

[rcurtin]

@MarkFischinger this seems to be a simpler solution to use in #224, any objection to using that instead?

Reply via ReviewNB

[rcurtin]

Hey @tunglinwood, I did not realize that both this PR and #224 were open for the same thing. I think that #224 is a more complete solution as it also fixes the other issues you pointed out in mlpack/mlpack#3655, but the fix for df.corr() here is cleaner in my opinion.

For the !pip install bit, I wouldn't mind hearing @zoq's opinions and others who have been more involved with the development of Python notebooks in the past. If we do it here, we should probably do it for all Python notebooks. But I think that the intention was that these could be run in mlpack Binder images, so mlpack and other dependencies would already be installed.

[mlpack-bot]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍