Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requirements for contribute #104

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Conversation

Aiden-Jeon
Copy link
Member

Signed-off-by: Jongseob Jeon aiden@Jongseobs-MacBook-Pro.local

Changes?

사이트 구성을 위한 백엔드 내용을 추가했습니다.

Why we need?

npm 이 어떤 것을 통해서 설치되는지, hugo에 대한 언급이 없어서 에러를 발생시킬 수 있습니다.

Test?

  • npm run start 를 수행하여 로컬에서 렌더링된 페이지를 확인하셨나요?
  • npm test 를 통과하였나요?

Anything Else? (Optional)

Signed-off-by: Jongseob Jeon <aiden@Jongseobs-MacBook-Pro.local>
@Aiden-Jeon Aiden-Jeon requested a review from a team as a code owner March 5, 2022 07:39
@Aiden-Jeon Aiden-Jeon requested review from anencore94 and zamonia500 and removed request for a team March 5, 2022 07:39
Copy link
Contributor

@zamonia500 zamonia500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Aiden-Jeon Aiden-Jeon merged commit 8ab63bc into main Mar 6, 2022
@Aiden-Jeon Aiden-Jeon deleted the enhance/add-requirements branch March 6, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants