Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

August 2023 dependency updates. #271

Merged
merged 4 commits into from
Aug 22, 2023
Merged

August 2023 dependency updates. #271

merged 4 commits into from
Aug 22, 2023

Conversation

erinesullivan
Copy link
Collaborator

@erinesullivan erinesullivan commented Aug 7, 2023

Overview

Monthly dependency update to help maintain Account.

NPM

These dependencies have been updated to their latest versions:

  • esbuild
  • eslint
  • eslint-plugin-import
  • sass

Ruby

Updated the ruby gems with bundle update

Environment files

Updated the environment files to follow the new naming convention.

Init script

Added an init.sh script which copies over the env.example file, copies the precommit git hook, builds the docker image, installs the gems and npm packages, and then builds the css / javascript.

Testing

  • Install the updated packages (docker-compose run --rm web npm install).
  • Make an SCSS change, and build the styles (docker-compose run --rm web npm run build-css).
  • Make a JS change, and build the scripts (docker-compose run --rm web npm run build-js).
  • Start the site to see if your change was made, and everything still works (docker-compose up).
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge

@erinesullivan erinesullivan added the dependencies Changes to packages or gems. label Aug 7, 2023
@erinesullivan erinesullivan self-assigned this Aug 7, 2023
Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are fine.

I updated the default environment file names and changed how to start up the application.

@niquerio niquerio merged commit 5de8fa1 into main Aug 22, 2023
1 check passed
@erinesullivan erinesullivan deleted the 2023-08-07-updates branch February 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to packages or gems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants