Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tests with openfl develop branch #772

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Sync tests with openfl develop branch #772

merged 6 commits into from
Jan 16, 2024

Conversation

scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Jan 16, 2024

Fixes #N.A.

Proposed Changes

  • updated nomenclature and api of openfl tests per latest changes in openfl develop

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

github-actions bot commented Jan 16, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

scap3yvt added a commit to scap3yvt/GaNDLF that referenced this pull request Jan 16, 2024
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati
Copy link
Collaborator

@psfoley: I think this seems to be an acceptable fix. Thoughts?

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6a42a8) 94.68% compared to head (ca4f44b) 94.68%.
Report is 4 commits behind head on master.

❗ Current head ca4f44b differs from pull request most recent head 6436fdd. Consider uploading reports for the commit 6436fdd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files         117      117           
  Lines        8242     8242           
=======================================
  Hits         7804     7804           
  Misses        438      438           
Flag Coverage Δ
unittests 94.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati merged commit 84a02d2 into master Jan 16, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
@sarthakpati sarthakpati deleted the scap3yvt-patch-1 branch January 16, 2024 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants