Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve workflow #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix and improve workflow #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a6cc6c
Fix and improve workflow
szepeviktor Oct 25, 2023
bae2034
Run only on PHP 8.1
szepeviktor Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 45 additions & 34 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# https://help.github.com/en/categories/automating-your-workflow-with-github-actions

on:
"pull_request": ~
"pull_request": null
Copy link
Author

@szepeviktor szepeviktor Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is the YAML base value.
People usually leave it empty but I am Explicit Viktor.

"push":
branches:
- 'main'
- "main"

name: "CI"

Expand All @@ -16,7 +16,7 @@ jobs:

steps:
- name: "Checkout"
uses: "actions/checkout@v3"
uses: "actions/checkout@v4"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade actions.


- name: "Run friendsofphp/php-cs-fixer"
run: |
Expand All @@ -29,16 +29,21 @@ jobs:

runs-on: "ubuntu-latest"

strategy:
matrix:
php-version:
- "8.1"

steps:
- name: "Checkout"
uses: "actions/checkout@v2"
uses: "actions/checkout@v4"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@v2"
with:
php-version: "${{ matrix.php-version }}"
coverage: "pcov"
tools: composer:2.5.x, php-cs-fixer:3.17.x, psalm:5.12.x
tools: "composer:2.5.x, php-cs-fixer:3.17.x, psalm:5.12.x"

- name: "Update dependencies with composer"
run: "composer update --no-ansi --no-interaction --no-progress"
Expand All @@ -59,17 +64,17 @@ jobs:

steps:
- name: "Checkout"
uses: "actions/checkout@v2"
uses: "actions/checkout@v4"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@v2"
with:
php-version: "${{ matrix.php-version }}"
coverage: "pcov"
tools: composer, phpunit:10.4
tools: "composer, phpunit:10.4"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v1"
uses: "actions/cache@v3"
with:
path: "~/.composer/cache"
key: "php${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-${{ hashFiles('**/composer.json') }}"
Expand All @@ -81,12 +86,16 @@ jobs:
- name: "Run tests with phpunit/phpunit"
run: "phpunit --coverage-clover=coverage.xml"

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
- name: "Upload coverage reports to Codecov"
uses: "codecov/codecov-action@v3"

rector-php-cs-fixer-pr:
name: PHP-CS-Fixer / Rector
name: "PHP-CS-Fixer / Rector"
runs-on: "ubuntu-latest"
strategy:
matrix:
php-version:
- "8.1"
if: github.actor != 'dependabot[bot]' && github.event_name == 'pull_request'
steps:
- name: "Checkout"
Expand All @@ -98,9 +107,9 @@ jobs:
with:
php-version: "${{ matrix.php-version }}"
coverage: "pcov"
tools: composer, phpunit:10.4
- name: Get PR Data
id: pr
tools: "composer, phpunit:10.4"
- name: "Get PR Data"
id: "pr"
run: |
cat "$GITHUB_EVENT_PATH" | jq .
export NUMBER=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH")
Expand All @@ -111,42 +120,44 @@ jobs:

export TITLE=$(jq --raw-output .pull_request.title "$GITHUB_EVENT_PATH")
echo "::set-output name=title::$TITLE"
- name: Checkout PR
- name: "Checkout PR"
run: |
git checkout ${{ steps.pr.outputs.branch }}
# —— Composer 🧙‍️ —————————————————————————————————————————————————————————
- name: Validate composer.json and composer.lock
run: composer validate
- name: Install Composer dependencies
run: composer install
# —— Run php-cs-fixer and rector 🧙‍️———————————————————————————————————————
- name: php-cs-fixer
- name: "Validate composer.json and composer.lock"
run: "composer validate"
- name: "Install Composer dependencies"
run: "composer install"
# —— Run php-cs-fixer and rector 🧙‍️ ——————————————————————————————————————
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make room here.

- name: "php-cs-fixer"
run: |
wget https://cs.symfony.com/download/php-cs-fixer-v3.phar -O php-cs-fixer
php php-cs-fixer fix
- name: commit php-cs-fixer changes
- name: "commit php-cs-fixer changes"
run: |
git diff --quiet && git diff --staged --quiet || git -c user.name='php-cs-fixer' -c user.email='php-cs-fixer@neubaukompass.de' commit -a -m "Changes by php-cs-fixer"
- name: rector
- name: "rector"
run: |
./vendor/bin/rector process
git add -u
- name: commit rector changes
- name: "commit rector changes"
run: |
git diff --quiet && git diff --staged --quiet || git -c user.name='rector' -c user.email='rector@neubaukompass.de' commit -a -m "Ruling the world via Rector!"
# —— Create PR if there are change 🧙‍️—————————————————————————————————————
- name: Create PR for CS fixups
uses: peter-evans/create-pull-request@v4 # renovate: tag=v4.0.2
id: create-pull-request
# —— Create PR if there are change 🧙‍️ ————————————————————————————————————
- name: "Create PR for CS fixups"
uses: "peter-evans/create-pull-request@v4" # renovate: tag=v4.0.2
id: "create-pull-request"
with:
token: ${{ secrets.GITHUB_TOKEN }}
title: "[rector] ${{ steps.pr.outputs.title }}"
base: ${{ steps.pr.outputs.branch }}
branch: rectified/${{ steps.pr.outputs.branch }}
branch: "rectified/${{ steps.pr.outputs.branch }}"
assignees: ${{ github.actor }}
labels: php-cs-fixer, rector
body: Please merge these changes into the ${{ steps.pr.outputs.branch }} branch to fix coding standard violations.
commit-message: Changed by rector in ${{ steps.pr.outputs.branch }}
- name: Fail the workflow when necessary CS fixes were detected
run: echo "Failing workflow run because CS violations were detected." && exit 1
labels: "php-cs-fixer, rector"
body: "Please merge these changes into the ${{ steps.pr.outputs.branch }} branch to fix coding standard violations."
commit-message: "Changed by rector in ${{ steps.pr.outputs.branch }}"
- name: "Fail the workflow when necessary CS fixes were detected"
run: |
echo "Failing workflow run because CS violations were detected."
exit 1
if: steps.create-pull-request.outputs.pr_number
Loading