Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve workflow #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

szepeviktor
Copy link

Matrix was referenced but non-existent.

@@ -1,10 +1,10 @@
# https://help.github.com/en/categories/automating-your-workflow-with-github-actions

on:
"pull_request": ~
"pull_request": null
Copy link
Author

@szepeviktor szepeviktor Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is the YAML base value.
People usually leave it empty but I am Explicit Viktor.

uses: "actions/checkout@v3"
uses: "actions/checkout@v4"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade actions.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #34 (bae2034) into main (3ac2e6c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #34   +/-   ##
=========================================
  Coverage     68.06%   68.06%           
  Complexity      294      294           
=========================================
  Files            23       23           
  Lines          1002     1002           
=========================================
  Hits            682      682           
  Misses          320      320           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

run: "composer validate"
- name: "Install Composer dependencies"
run: "composer install"
# —— Run php-cs-fixer and rector 🧙‍️ ——————————————————————————————————————
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make room here.

@szepeviktor
Copy link
Author

szepeviktor commented Oct 25, 2023

❌ "Get PR Data" step does not work in this PR from a fork.
This is a debug tool: https://github.com/szepeviktor/byte-level-care/blob/167ea9e2d9368dd5c7d62488cd31af0a88e2bdd3/.github/workflows/workflow.yml#L48-L54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant