Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Unbreak linting #95

Merged
merged 1 commit into from
Oct 22, 2022
Merged

CI: Unbreak linting #95

merged 1 commit into from
Oct 22, 2022

Conversation

mjpieters
Copy link
Owner

The doit command would trigger _poetry_install, which runs poetry
without the -E docs extra. Recent poetry versions now uninstall everything
related to the extras not explicitly listed, breaking any docs linting
steps. Explicitly ignoring the task is easiest.

At the same time, upgrade black to a version that doesn't break rely on
private internals of click that have since been removed.

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f1b5644) compared to base (b0eb600).
Patch has no changes to coverable lines.

❗ Current head f1b5644 differs from pull request most recent head 5826902. Consider uploading reports for the commit 5826902 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           60        60           
  Branches         7         6    -1     
=========================================
  Hits            60        60           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

The doit command would trigger _poetry_install, which runs poetry
without the `-E docs` extra. Recent poetry versions now uninstall everything
related to the extras not explicitly listed, breaking any docs linting
steps. Explicitly ignoring the task is easiest.

At the same time, upgrade black to a version that doesn't break rely on
private internals of click that have since been removed.
@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mjpieters mjpieters merged commit 6697d2e into master Oct 22, 2022
@mjpieters mjpieters deleted the unbreak_linting branch October 22, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant