Skip to content

Commit

Permalink
pin net-telnet dependency to keep ruby support for < 2.3
Browse files Browse the repository at this point in the history
Also added todo comments to come back and remove it at a later date and to pin to a min version of ruby at some point.

Signed-off-by: Ben Abrams <me@benabrams.it>
  • Loading branch information
majormoses committed Sep 23, 2018
1 parent 259cf46 commit 55722d0
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion specinfra.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]
# TODO: at some point pin to a minumum version of ruby to reduce support burden in a major version bump
# spec.required_ruby_version = '>= 2.3.0'

spec.add_runtime_dependency "net-scp"
spec.add_runtime_dependency "net-ssh", ">= 2.7"
spec.add_runtime_dependency "net-telnet"
# TODO: remove the lock when you want to ruby ruby < 2.3 support
spec.add_runtime_dependency "net-telnet", "0.1.1"
spec.add_runtime_dependency "sfl"

spec.add_development_dependency "bundler", "~> 1.3"
Expand Down

0 comments on commit 55722d0

Please sign in to comment.