Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ungettext_lazy for Django 4.0 #69

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

mnemchinov
Copy link
Contributor

@mnemchinov mnemchinov commented Jan 13, 2022

This closes #68

@AngelOnFira AngelOnFira changed the title fix #68 Fix ungettext_lazy for Django 4.0 Feb 23, 2022
@AngelOnFira
Copy link
Collaborator

AngelOnFira commented Feb 23, 2022

For another reference, this is in Django's docs.

@AngelOnFira
Copy link
Collaborator

I'm not sure why CI didn't run on this, but the changes look good to me. Sorry for taking so long to check it out!

@AngelOnFira
Copy link
Collaborator

AngelOnFira commented Feb 23, 2022

An update, it seems like ungettext_lazy was just an alias for ngettext_lazy, and that was the recommended fix. I've pushed a commit that changes to that.

Reference: https://docs.djangoproject.com/en/dev/releases/3.0/#id3

@AngelOnFira AngelOnFira merged commit 23ec5a7 into mixxorz:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'ungettext_lazy' from 'django.utils.translation'
2 participants