Detect snapshot names from function names #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to detect the snapshot names form the current thread. This has been very unrealiable in a lot of cases. This changes the behavior so that the function name is used instead by using `std::any::type_name`. This does change behavior slightly but most users should not notice this change except if they relied on helper functions. In that case using a macro is a better solution most likely. Refs #127 and #105
mitsuhiko
added a commit
to getsentry/symbolicator
that referenced
this pull request
Jan 25, 2022
Future insta versions no longer use thread but function name. Refs mitsuhiko/insta#213
mitsuhiko
added a commit
to getsentry/symbolicator
that referenced
this pull request
Jan 26, 2022
Future insta versions no longer use thread but function name. Refs mitsuhiko/insta#213
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to detect the snapshot names form the current thread. This has
been very unrealiable in a lot of cases. This changes the behavior so
that the function name is used instead by using
std::any::type_name.This does change behavior slightly but most users should not notice this
change except if they relied on helper functions. In that case using a
macro is a better solution most likely.
Refs #127 and #105