added checks to ensure some kernel modules are properly configured to be blacklisted #44
+111
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be blacklisted Signed-off-by: kemley76 <kemley@mitre.org>
wdower
requested changes
Jun 13, 2024
| @@ -32,4 +32,17 @@ | |||
| it { should be_disabled } | |||
| it { should be_blacklisted } | |||
| end | |||
|
|
|||
| config_files = command('find /etc/modprobe.conf /etc/modprobe.d/* -print0').stdout.split("\0") | |||
There was a problem hiding this comment.
Why is this one a slightly different pattern compared to the rest?
There was a problem hiding this comment.
I'm not sure why I wrote it that way. It should be fixed now.
Signed-off-by: kemley76 <kemley@mitre.org>
Signed-off-by: kemley76 <kemley@mitre.org>
aaronlippold
requested changes
Jul 8, 2024
| @@ -32,4 +32,17 @@ | |||
| it { should be_disabled } | |||
| it { should be_blacklisted } | |||
| end | |||
|
|
|||
| config_files = command('find /etc/modprobe.conf /etc/modprobe.d/* -print0').stdout.split("\0") | |||
There was a problem hiding this comment.
Does the kernel_module resource not do this for you already?
There was a problem hiding this comment.
There was a problem hiding this comment.
It appears so. I was under the impression that kernel_module was testing the results of the configuration being loaded (maybe using something lsmod or modprobe command itself) rather than directly looking at how it was configured. In this case, this means that this whole PR is redundant, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to issue #40