V1r2 #37
Merged
V1r2 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wdower <will@dower.dev>
…ta not run yet) Signed-off-by: wdower <will@dower.dev>
Signed-off-by: wdower <will@dower.dev>
Signed-off-by: wdower <will@dower.dev>
Signed-off-by: wdower <will@dower.dev>
Signed-off-by: wdower <will@dower.dev>
Signed-off-by: wdower <will@dower.dev>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <will@dower.dev>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
… use (can add keys to the hash for other file mode checks later Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
…Y have the 'is_router' caveat if that caveat is explicitly described in the check text Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
Amndeep7
requested changes
May 6, 2024
Amndeep7
requested changes
May 7, 2024
Amndeep7
requested changes
May 7, 2024
…, bumped upload-artifact version, removed unneeded pipeline step Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
… in 257937 Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
… name conflicts Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Amndeep7
requested changes
May 15, 2024
…h, adding some caveat inputs for network settings that need to be enabled Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Co-authored-by: Amndeep Singh Mann <me@asm.works>
Amndeep7
requested changes
May 15, 2024
| } | ||
|
|
||
| parameter = 'kernel.core_pattern' | ||
| value = 1 |
There was a problem hiding this comment.
Suggested change
| value = 1 | |
| value = "|/bin/false" |
| !virtualization.system.eql?('docker') | ||
| } | ||
|
|
||
| exempt_home_users = input('exempt_home_users') |
There was a problem hiding this comment.
input naming is inconsistent - sometimes 'exempt' vs 'exemptions' and having that keyword at the beginning or end of the name (beginning here, others have it at the end)
| @@ -23,4 +23,14 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
| @@ -23,4 +23,14 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
| @@ -23,4 +23,14 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
| @@ -23,4 +23,14 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
| @@ -23,4 +23,10 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
Amndeep7
requested changes
May 16, 2024
| @@ -23,4 +23,10 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
|
|
||
| describe file('/etc/group') do | ||
| it { should exist } | ||
| its('group') { should cmp 'root' } |
There was a problem hiding this comment.
can't we use the grouped_into function here?
this comment applies to all the controls that are having us (as opposed to presumably the resource) directly do string comparison to check the group
Suggested change
| its('group') { should cmp 'root' } | |
| it { should be_grouped_into 'root' } |
| @@ -23,4 +23,10 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
| @@ -23,4 +23,10 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
| @@ -23,4 +23,10 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
|
|
||
| audit_tools = ['/sbin/auditctl', '/sbin/aureport', '/sbin/ausearch', '/sbin/autrace', '/sbin/auditd', '/sbin/rsyslogd', '/sbin/augenrules'] | ||
|
|
||
| failing_tools = audit_tools.reject { |at| file(at).owned_by?('root') } |
There was a problem hiding this comment.
huh, I think I like reject better than the filter NOTs that have been happening elsewhere. maybe this could be added as another todo item on the consistency fixes issue?
|
|
||
| audit_tools = ['/sbin/auditctl', '/sbin/aureport', '/sbin/ausearch', '/sbin/autrace', '/sbin/auditd', '/sbin/rsyslogd', '/sbin/augenrules'] | ||
|
|
||
| failing_tools = audit_tools.reject { |at| file(at).group == 'root' } |
There was a problem hiding this comment.
this should probably still be using the grouped_into func instead of doing a straight string comparison
Suggested change
| failing_tools = audit_tools.reject { |at| file(at).group == 'root' } | |
| failing_tools = audit_tools.reject { |at| file(at).grouped_into? 'root' } |
| @@ -29,4 +29,15 @@ | |||
| tag 'documentable' | |||
| tag cci: ['CCI-000366'] | |||
| tag nist: ['CM-6 b'] | |||
| tag 'host', 'container' | |||
There was a problem hiding this comment.
Suggested change
| tag 'host', 'container' | |
| tag 'host' | |
| tag 'container' |
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Co-authored-by: Amndeep Singh Mann <me@asm.works>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
…imdall for an easier time hooking it up with kitchen Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
…7949 Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing profile repo at v1r2.