lint

Signed-off-by: wdower <57142072+wdower@users.noreply.github.com>

controls/SV-258046.rb

@@ -47,5 +47,4 @@
       expect(non_interactive_shells).to be_empty, "Non-interactive system accounts with interactive shells:\n\t- #{non_interactive_shells.join("\n\t- ")}"
     end
   end
-
 end

controls/SV-258055.rb

@@ -38,6 +38,6 @@
   }
 
   describe command('grep even_deny_root /etc/security/faillock.conf').stdout.strip do
-    it { should match(%r{^even_deny_root$}) }
+    it { should match(/^even_deny_root$/) }
   end
 end

controls/SV-258061.rb

@@ -21,10 +21,10 @@
   tag nist: ['IA-2']
   tag 'host', 'container'
 
-  duplicate_gids = command("cut -d : -f 3 /etc/group | uniq -d").stdout.strip.split
+  duplicate_gids = command('cut -d : -f 3 /etc/group | uniq -d').stdout.strip.split
 
-  describe "All GIDs" do
-    it "should be unique" do
+  describe 'All GIDs' do
+    it 'should be unique' do
       expect(duplicate_gids).to be_empty, "GIDs with more than one group name:\n\t- #{duplicate_gids.join("\n\t- ")}"
     end
   end

controls/SV-258072.rb

@@ -37,18 +37,16 @@
 
   expected_umask = input('permissions_for_shells')[:bashrc_umask]
 
-  umask_check = command("grep umask #{file}").stdout.strip.match(%r{^umask\s+(?<umask>\d+)$})
+  umask_check = command("grep umask #{file}").stdout.strip.match(/^umask\s+(?<umask>\d+)$/)
 
   if umask_check.nil?
     describe "UMASK should be set in #{file}" do
       subject { umask_check }
       it { should_not be_nil }
     end
   else
-    if umask_check[:umask] == '0000' || umask_check[:umask] == '000'
-      impact 0.7
-    end
-    describe "UMASK" do
+    impact 0.7 if umask_check[:umask] == '0000' || umask_check[:umask] == '000'
+    describe 'UMASK' do
       subject { umask_check[:umask] }
       it { should cmp expected_umask }
     end

controls/SV-258073.rb

@@ -37,18 +37,16 @@
 
   expected_umask = input('permissions_for_shells')[:cshrc_umask]
 
-  umask_check = command("grep umask #{file}").stdout.strip.match(%r{^umask\s+(?<umask>\d+)$})
+  umask_check = command("grep umask #{file}").stdout.strip.match(/^umask\s+(?<umask>\d+)$/)
 
   if umask_check.nil?
     describe "UMASK should be set in #{file}" do
       subject { umask_check }
       it { should_not be_nil }
     end
   else
-    if umask_check[:umask] == '0000' || umask_check[:umask] == '000'
-      impact 0.7
-    end
-    describe "UMASK" do
+    impact 0.7 if umask_check[:umask] == '0000' || umask_check[:umask] == '000'
+    describe 'UMASK' do
       subject { umask_check[:umask] }
       it { should cmp expected_umask }
     end

controls/SV-258075.rb

@@ -36,18 +36,16 @@
 
   expected_umask = input('permissions_for_shells')[:profile_umask]
 
-  umask_check = command("grep umask #{file}").stdout.strip.match(%r{^umask\s+(?<umask>\d+)$})
+  umask_check = command("grep umask #{file}").stdout.strip.match(/^umask\s+(?<umask>\d+)$/)
 
   if umask_check.nil?
     describe "UMASK should be set in #{file}" do
       subject { umask_check }
       it { should_not be_nil }
     end
   else
-    if umask_check[:umask] == '0000' || umask_check[:umask] == '000'
-      impact 0.7
-    end
-    describe "UMASK" do
+    impact 0.7 if umask_check[:umask] == '0000' || umask_check[:umask] == '000'
+    describe 'UMASK' do
       subject { umask_check[:umask] }
       it { should cmp expected_umask }
     end

controls/SV-258083.rb

@@ -26,7 +26,7 @@
   tag cci: ['CCI-002235']
   tag nist: ['AC-6 (10)']
   tag 'host'
-  
+
   only_if('This control is Not Applicable to containers', impact: 0.0) {
     !(virtualization.system.eql?('docker') && !file('/etc/ssh/sshd_config').exist?)
   }