Change addPotentialLink to have ability: link in response. #2346

cyber-arsenull · 2021-11-02T01:14:38Z

Description

Currently link is unpacked into the response, but in the operation_api_manager.py create_potential_link, which handles this request, it is expected that the data has an ability key. Since there is none, when it goes to build an ability it builds a default 'manual' one instead.

This can be tested by making an operation, and then adding a potential link.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Set breakpoint in create_potential_link in operation_api_manager.py
Start server with debugger attached
Start agent
Start operation
Add potential link manually
At breakpoint trigger step until ability = self.build_ability(data=data.pop('ability', {}), executor=executor)
Check that ability is correctly made (and is not labeled "manual ability" from default values in build_ability)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
[] I have added tests that prove my fix is effective or that my feature works

Currently link is unpacked into the response, but in the operation_api_manager.py create_potential_link which handles this request it is expected that the data has an ability key. Since there is none, when it goes to build an ability it builds a default 'manual' one instead. This can be tested by making an operation, and then adding a potential link.

github-actions

Wohoo! Your first PR -- thanks for contributing!

codecov · 2021-11-02T01:15:55Z

Codecov Report

Merging #2346 (3e5f40a) into master (b816e9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2346   +/-   ##
=======================================
  Coverage   72.60%   72.60%           
=======================================
  Files         110      110           
  Lines        7946     7946           
=======================================
  Hits         5769     5769           
  Misses       2177     2177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b816e9c...3e5f40a. Read the comment docs.