Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved confetti.min.js to core library, updated training plugin with completed certificate message #2342

Merged
merged 6 commits into from
Nov 10, 2021

Conversation

iguannalin
Copy link
Contributor

@iguannalin iguannalin commented Nov 1, 2021

Description

Confetti.min.js is no longer working in training plugin due to import issues with Alpine, now moved to shared core library so it can preloaded before the training plugin. Pinned training plugin to latest version.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@iguannalin iguannalin self-assigned this Nov 1, 2021
argaudreau
argaudreau previously approved these changes Nov 1, 2021
Copy link
Contributor

@argaudreau argaudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The confetti is a must have 🎉

trich2213
trich2213 previously approved these changes Nov 8, 2021
Copy link

@trich2213 trich2213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work. good to go.

@iguannalin iguannalin enabled auto-merge (squash) November 8, 2021 20:11
@iguannalin iguannalin dismissed stale reviews from trich2213 and argaudreau via 2bfa59e November 10, 2021 15:38
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #2342 (298f935) into master (514c144) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2342   +/-   ##
=======================================
  Coverage   72.60%   72.60%           
=======================================
  Files         110      110           
  Lines        7946     7946           
=======================================
  Hits         5769     5769           
  Misses       2177     2177           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514c144...298f935. Read the comment docs.

@iguannalin iguannalin merged commit 78d66ce into master Nov 10, 2021
@iguannalin iguannalin deleted the training-certificate-complete-pin branch November 10, 2021 16:21
cyber-arsenull pushed a commit that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants