Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyright scanning and consolidate typecheck action logic #377

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Fix pyright scanning and consolidate typecheck action logic #377

merged 3 commits into from
Jan 4, 2023

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented Jan 4, 2023

  • The presence of a # type: ignore in the file header in tests/annotations/declarations.py prevented pyright 1.1.285+ from scanning it
  • consolidate type-check job logic to prevent redundant job info
  • manage pyright version w/ dependabot

@rsokl rsokl added test suite Changes to hydra-zen's test suite type-checking Involves hydra_zen.typing or pyright/mypy labels Jan 4, 2023
@rsokl rsokl merged commit 91ba1a6 into main Jan 4, 2023
@rsokl rsokl deleted the improve-ci branch January 4, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test suite Changes to hydra-zen's test suite type-checking Involves hydra_zen.typing or pyright/mypy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rsokl