Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve type annotation for builds -- target must be callable #200

Merged
merged 2 commits into from
Jan 13, 2022
Merged

improve type annotation for builds -- target must be callable #200

merged 2 commits into from
Jan 13, 2022

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented Jan 13, 2022 •
edited
Loading

Before:

builds(1)  # OK to static type-checkers

After:

builds(1)  # marked as invalid by static type-checkers

@rsokl rsokl added enhancement New feature or request type-checking Involves hydra_zen.typing or pyright/mypy labels Jan 13, 2022
@rsokl rsokl added this to the hydra-zen 0.5.0 milestone Jan 13, 2022
@rsokl rsokl merged commit 764eee6 into main Jan 13, 2022
@rsokl rsokl deleted the improve-hint branch January 13, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request type-checking Involves hydra_zen.typing or pyright/mypy
Projects
None yet
Milestone
hydra-zen 0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rsokl