Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate type info and unpin pyright #180

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Fix inaccurate type info and unpin pyright #180

merged 2 commits into from
Dec 22, 2021

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented Dec 22, 2021

Fixes some inaccuracies / incompleteness in the type ZenWrappers

This bug in pyright 1.1.198 has been fixed. Minimum version of pyright on our CI is now 1.1.199 (the latest release as of posting this).

The newest version of pyright located some incomplete type annotations, which this PR also fixes.

@rsokl rsokl added the type-checking Involves hydra_zen.typing or pyright/mypy label Dec 22, 2021
@rsokl rsokl merged commit 2779909 into main Dec 22, 2021
@rsokl rsokl deleted the unpin-pyright branch December 22, 2021 17:09
@rsokl rsokl added this to the hydra-zen 0.5.0 milestone Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-checking Involves hydra_zen.typing or pyright/mypy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant