Change behavior of pop-full-sig to take priority over inherited fields #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
builds
whenpopulate_full_signature=True
and one or more base-classes are specified for inheritance. Note that this a compatibility-breaking change. Although the old behavior was likely not what one wanted/expected.Previously, fields specified by the parent class would take priority over those that would be auto-populated:
Before
However, this behavior is unintuitive, as
populate_full_signature=True
should behave identically as the case where one manually-specifies the arguments from a target's signature. Thus we have have changed this behavior such that auto-populating and manually-populating fields from a signature always produces the same behavior:After