Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zen_wrapper should support partial'd wrappers #314

Closed
rsokl opened this issue Oct 11, 2022 · 0 comments
Closed

zen_wrapper should support partial'd wrappers #314

rsokl opened this issue Oct 11, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
hydra-zen 0.9.0

Comments

@rsokl
Copy link
Contributor

rsokl commented Oct 11, 2022 •
edited
Loading

This should work:

builds(something, zen_wrappers=partial(my_wrapper, param=100))

Currently, one would have to write:

builds(something, zen_wrappers=builds(my_wrapper, param=100, zen_partial=True))

we just need to check if a wrapper is an instance of partial and auto-apply hydra_zen.just if so.
@rsokl rsokl added enhancement New feature or request good first issue Good for newcomers labels Oct 11, 2022
@rsokl rsokl added this to the hydra-zen 0.9.0 milestone Dec 30, 2022
@rsokl rsokl closed this as completed in 2380865 Dec 30, 2022
rsokl added a commit that referenced this issue Dec 30, 2022
@rsokl
Merge pull request #367 from mit-ll-responsible-ai/partial-zen-wrapper
d30ed1b 
closes #314 -- zen_wrappers accepts partial'd functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
hydra-zen 0.9.0
Development

No branches or pull requests
1 participant
@rsokl