Merge pull request #571 from mit-ll-responsible-ai/passthrough

Make ZenStore.update noop for identical stores
mit-ll-responsible-ai · Nov 8, 2023 · 43948b1 · 43948b1
2 parents 9720ac4 + d9189bd
commit 43948b1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/hydra_zen/wrapper/_implementations.py b/src/hydra_zen/wrapper/_implementations.py
@@ -1755,6 +1755,9 @@ def update(self, __other: "ZenStore") -> None:
         s3
         {None: ['g']}
         """
+        if __other == self:
+            return
+
         self._internal_repo.update(deepcopy(__other._internal_repo))
         self._queue.update(__other._queue)
         if not self._deferred_store:

diff --git a/tests/test_store.py b/tests/test_store.py
@@ -938,8 +938,8 @@ def test_update():
 
     s3 = s1(group="BB")
     assert s3 == s1
-    s1 |= s2
 
+    s1 |= s2
     assert len(s1) == 3
     assert s1._queue == {(None, "a"), (None, "b"), ("G", "c")}
     assert s1._internal_repo[None, "b"] is not s2._internal_repo[None, "b"]
@@ -951,6 +951,9 @@ def test_update():
     s3({}, name="foo")
     assert ("BB", "foo") in s1
 
+    s1 |= s3
+    assert s3 == s1
+
 
 @pytest.mark.usefixtures("clean_store")
 def test_update_respects_add_to_hydra_store():